----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61123/#review181467 -----------------------------------------------------------
Fix it, then Ship it! LGTM! The comment is mostly a question. src/tests/containerizer/linux_filesystem_isolator_tests.cpp Lines 252-255 (patched) <https://reviews.apache.org/r/61123/#comment257073> Why do we need Docker for this test? The problem should be reproducible without it. - Ilya Pronin On July 26, 2017, 12:05 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61123/ > ----------------------------------------------------------- > > (Updated July 26, 2017, 12:05 a.m.) > > > Review request for mesos, Ilya Pronin, Jie Yu, James Peach, Stephan Erb, > Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-5187 > https://issues.apache.org/jira/browse/MESOS-5187 > > > Repository: mesos > > > Description > ------- > > Added regression test for host volume ownership issue. > > > Diffs > ----- > > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > 457311e23a0c848ef3ed69c8be4396e6a01f3b95 > > > Diff: https://reviews.apache.org/r/61123/diff/1/ > > > Testing > ------- > > make check > > Verified that this test failed if we don't have the bugfix patch. > > > Thanks, > > Gilbert Song > >
