----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61245/#review181880 -----------------------------------------------------------
src/tests/slave_tests.cpp Lines 7878 (patched) <https://reviews.apache.org/r/61245/#comment257671> s/inexistent/non-existent src/tests/slave_tests.cpp Lines 7898 (patched) <https://reviews.apache.org/r/61245/#comment257672> s/inexistent/non-existent src/tests/slave_tests.cpp Lines 7934 (patched) <https://reviews.apache.org/r/61245/#comment257674> This code seems to be duplicated. I think you can use a parameterized test over here similar to this: https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L104 src/tests/slave_tests.cpp Lines 7955-7972 (patched) <https://reviews.apache.org/r/61245/#comment257675> Ditto for using parameterized tests here for CNI and CNM. - Avinash sridharan On July 30, 2017, 3:32 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61245/ > ----------------------------------------------------------- > > (Updated July 30, 2017, 3:32 p.m.) > > > Review request for mesos, Avinash sridharan and Jie Yu. > > > Bugs: MESOS-7709 > https://issues.apache.org/jira/browse/MESOS-7709 > > > Repository: mesos > > > Description > ------- > > Added a test `SlaveTest.ValidateDefaultContainerDNSFlag`. > > > Diffs > ----- > > src/tests/slave_tests.cpp a089cc47eae41cd6baeffd3f4a7ee7c7984aacbd > > > Diff: https://reviews.apache.org/r/61245/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
