> On Aug. 2, 2017, 11:51 p.m., Avinash sridharan wrote: > > src/tests/slave_tests.cpp > > Lines 7942 (patched) > > <https://reviews.apache.org/r/61245/diff/3/?file=1787860#file1787860line7942> > > > > We could do something like: > > ``` > > string network_mode = (containerizer == "mesos" ? "CNI" : "USER"); > > > > defaultContainerDNSInfo = > > "--default_container_dns={" > > " \"" + containerizer + "\": [\n" > > " {\n" > > " \"network_mode\": + network_mode+ ",\n" > > " \"dns\": {\n" > > " \"nameservers\": [ \"8.8.8.8\" ]\n" > > " }\n" > > " },\n" > > " {\n" > > " \"network_mode\": \"CNI\",\n" > > " \"dns\": {\n" > > " \"nameservers\": [ \"8.8.8.8\" ]\n" > > " }\n" > > " }\n" > > " ]\n" > > "}"; > > > > ``` > > > > That way we wouldn't need the `else` ocondtitional below ?
+1. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61245/#review181997 ----------------------------------------------------------- On Aug. 2, 2017, 4:15 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61245/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2017, 4:15 p.m.) > > > Review request for mesos, Avinash sridharan and Jie Yu. > > > Bugs: MESOS-7709 > https://issues.apache.org/jira/browse/MESOS-7709 > > > Repository: mesos > > > Description > ------- > > Added a test `DefaultContainerDNSFlagTest.ValidateFlag`. > > > Diffs > ----- > > src/tests/slave_tests.cpp a8c3a7749472739c72de2deebe6220c724e635bb > > > Diff: https://reviews.apache.org/r/61245/diff/3/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
