> On Aug. 1, 2017, 2:51 p.m., Avinash sridharan wrote: > > src/tests/slave_tests.cpp > > Lines 7934 (patched) > > <https://reviews.apache.org/r/61245/diff/1/?file=1785603#file1785603line7934> > > > > This code seems to be duplicated. I think you can use a parameterized > > test over here similar to this: > > > > https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L104
Can you elaborate a bit about this? Did you mean the strings I assigned to `argv[3]` for CNI and CNM are duplicated? They are very similar but still have difference, e.g., for CNI, the field name is `mesos`, but for CNM, the field name is `docker`, and also the network modes are different (`CNI` v.s. `USER`). So we need different strings anyway, I am not sure how we can parameterize them. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61245/#review181880 ----------------------------------------------------------- On July 30, 2017, 11:32 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61245/ > ----------------------------------------------------------- > > (Updated July 30, 2017, 11:32 p.m.) > > > Review request for mesos, Avinash sridharan and Jie Yu. > > > Bugs: MESOS-7709 > https://issues.apache.org/jira/browse/MESOS-7709 > > > Repository: mesos > > > Description > ------- > > Added a test `SlaveTest.ValidateDefaultContainerDNSFlag`. > > > Diffs > ----- > > src/tests/slave_tests.cpp a089cc47eae41cd6baeffd3f4a7ee7c7984aacbd > > > Diff: https://reviews.apache.org/r/61245/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
