----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61697/#review183071 -----------------------------------------------------------
src/checks/checker_process.cpp Lines 143-144 (patched) <https://reviews.apache.org/r/61697/#comment259076> "returns the merged stdout and stderr": is this true? Looks like you only use STDOUT type events here? src/checks/checker_process.cpp Lines 145 (patched) <https://reviews.apache.org/r/61697/#comment259074> s/It/This function/ src/checks/checker_process.cpp Lines 153 (patched) <https://reviews.apache.org/r/61697/#comment259079> So this fuction expects a stream with ContentType of protobuf; could you call this out in the comment above the function declaration? src/checks/checker_process.cpp Lines 543-545 (original), 581-583 (patched) <https://reviews.apache.org/r/61697/#comment259080> Could you extend this comment with TODO explaining why we want to switch to a streaming response (for logging of hung checks), with a reference to a relevant JIRA? - Greg Mann On Aug. 16, 2017, 8:17 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61697/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2017, 8:17 p.m.) > > > Review request for mesos, Alexander Rukletsov and Vinod Kone. > > > Bugs: MESOS-7861 > https://issues.apache.org/jira/browse/MESOS-7861 > > > Repository: mesos > > > Description > ------- > > This patch makes the default executor include the output of the COMMAND > (health) checks in its logs. > > > Diffs > ----- > > src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e > > > Diff: https://reviews.apache.org/r/61697/diff/2/ > > > Testing > ------- > > Manual tests. > > > Thanks, > > Gastón Kleiman > >
