> On Aug. 21, 2017, 1:34 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 644-650 (patched) > > <https://reviews.apache.org/r/61697/diff/3/?file=1800326#file1800326line644> > > > > I'd rather `VLOG(1)` here. It seems we do `LOG(INFO)` for important > > messages in this file (3 occurences). It is also consistent with other > > checks.
IMO, in this case it will be more useful for our users if we include this in non-verbose logs. Using VLOG would mean that in order to get the output, a user would likely need to pass MESOS_VERBOSE=true and GLOG_v=2 env vars to the executor. If a bug occurs and reproducing the issue is difficult, then it could be hard for the user to get the relevant check logs. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61697/#review183331 ----------------------------------------------------------- On Aug. 18, 2017, 11:20 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61697/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2017, 11:20 p.m.) > > > Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-7861 > https://issues.apache.org/jira/browse/MESOS-7861 > > > Repository: mesos > > > Description > ------- > > This patch makes the default executor include the output of the COMMAND > (health) checks in its logs. > > > Diffs > ----- > > src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e > > > Diff: https://reviews.apache.org/r/61697/diff/3/ > > > Testing > ------- > > Manual tests. > > > Thanks, > > Gastón Kleiman > >
