> On Aug. 17, 2017, 2:22 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 855-858 (original), 903-906 (patched) > > <https://reviews.apache.org/r/61697/diff/2/?file=1798839#file1798839line903> > > > > While we're on it, let's consistently print out HTTP and TCP check > > output. Instead of including it into the failure. As a separate patch, > > please.
Do you mean that we should always print the output of the HTTP/TCP commands? We're including it in the Failure here, because in this case curl returned something unexpected, otherwise I don't think it makes much sense to print the exit status and output of curl. Anyway, I made the output more consistent here: https://reviews.apache.org/r/61766/. Let's continue this conversation there. > On Aug. 17, 2017, 2:22 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 999-1009 (original), 1047-1057 (patched) > > <https://reviews.apache.org/r/61697/diff/2/?file=1798839#file1798839line1047> > > > > Ditto. Let's make the output consistent. Ditto https://reviews.apache.org/r/61766/. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61697/#review183121 ----------------------------------------------------------- On Aug. 18, 2017, 11:20 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61697/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2017, 11:20 p.m.) > > > Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-7861 > https://issues.apache.org/jira/browse/MESOS-7861 > > > Repository: mesos > > > Description > ------- > > This patch makes the default executor include the output of the COMMAND > (health) checks in its logs. > > > Diffs > ----- > > src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e > > > Diff: https://reviews.apache.org/r/61697/diff/3/ > > > Testing > ------- > > Manual tests. > > > Thanks, > > Gastón Kleiman > >
