> On Aug. 21, 2017, 6:10 p.m., Greg Mann wrote: > > src/checks/checker_process.cpp > > Lines 149-150 (patched) > > <https://reviews.apache.org/r/61697/diff/3/?file=1800326#file1800326line149> > > > > This seems more concise to me, and just as readable: > > > > s/stdoutReceived/stdout/ > > s/stderrReceived/stderr/ > > > > what do you think?
I associate `stdout` and `stderr` with the global variables from `stdio.h`, which are used for the stdout/stderr of the *current* process. And apparently I am not the only one, for instance vim highlights them differently. I checked with Greg on Slack and he's ok with keeping the current names, so I'm dropping this issue. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61697/#review183351 ----------------------------------------------------------- On Aug. 21, 2017, 7:08 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61697/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2017, 7:08 p.m.) > > > Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-7861 > https://issues.apache.org/jira/browse/MESOS-7861 > > > Repository: mesos > > > Description > ------- > > This patch makes the default executor include the output of the COMMAND > (health) checks in its logs. > > > Diffs > ----- > > src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e > > > Diff: https://reviews.apache.org/r/61697/diff/4/ > > > Testing > ------- > > Manual tests. > > > Thanks, > > Gastón Kleiman > >
