----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60591/#review183566 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 240-241 (patched) <https://reviews.apache.org/r/60591/#comment259609> Better to change to: ``` agentPorts = rangesToIntervalSet<uint16_t>(resources->ports().get()).get(); ``` src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 243-251 (patched) <https://reviews.apache.org/r/60591/#comment259610> Not yours, but it seems that we do not have this check for agent's `--resources` flag, so that means operator can specify an incorrect port range (e.g., `[888888-999999]` in that flag? - Qian Zhang On Aug. 22, 2017, 4:36 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60591/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2017, 4:36 a.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Normally, the `network/ports` isolator will kill any task that > listens on a port that it does not have resources for. However, > executors that are based on the libprocess API will always listen > on a port in the ephemeral range, and we want to make it possible > to use libprocess-based executors. > > Added the `--container_ports_watch_resources_only` option to only > kill tasks when they listen on un-allocated ports within the port > range published by the agent resources. This still prevents port > collisions between tasks, but doesn't kill them just because the > executor is listening on a port. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION > src/slave/flags.hpp 2970fea0cfac6af275a758d4bfedfe9a943c2b60 > src/slave/flags.cpp 3b02f3e909a554f15104739832ae3f252926b45f > > > Diff: https://reviews.apache.org/r/60591/diff/13/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
