> On Aug. 22, 2017, 9:09 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 183 (patched) > > <https://reviews.apache.org/r/60591/diff/12/?file=1801019#file1801019line183> > > > > Usually we put the declaration of static function at the beginning of > > the file, and put its implemention in the end. You can take `slave.cpp` and > > `master.cpp` as references.
This isn't in the style guide and it's rare that we use forward declarations unless they are necessary, eg. `src/linux/cgroups.cpp`, `src/launcher/fetcher.cpp`, `src/common/http.cpp`. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60591/#review183420 ----------------------------------------------------------- On Aug. 23, 2017, 9:57 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60591/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2017, 9:57 p.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Normally, the `network/ports` isolator will kill any task that > listens on a port that it does not have resources for. However, > executors that are based on the libprocess API will always > listen on a port in the ephemeral range, and we want to make > it possible to use libprocess-based executors. > > Added the `--check_agent_port_range_only` option to only kill > tasks when they listen on un-allocated ports within the port > range published by the agent resources. This still prevents > port collisions between tasks, but doesn't kill them just > because the executor is listening on a port. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION > src/slave/flags.hpp 2970fea0cfac6af275a758d4bfedfe9a943c2b60 > src/slave/flags.cpp 3b02f3e909a554f15104739832ae3f252926b45f > > > Diff: https://reviews.apache.org/r/60591/diff/15/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
