----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60593/#review183580 -----------------------------------------------------------
src/tests/containerizer/ports_isolator_tests.cpp Lines 701-703 (patched) <https://reviews.apache.org/r/60593/#comment259635> Why do we need these? src/tests/containerizer/ports_isolator_tests.cpp Lines 853 (patched) <https://reviews.apache.org/r/60593/#comment259643> It seems there is no enough time left for this code because we stop the `driver` right after the check is triggered. src/tests/containerizer/ports_isolator_tests.cpp Lines 871-873 (patched) <https://reviews.apache.org/r/60593/#comment259644> I think this test should belong to r/60594 since it is not related to slave recovery. - Qian Zhang On July 13, 2017, 12:58 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60593/ > ----------------------------------------------------------- > > (Updated July 13, 2017, 12:58 p.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Added a test for the `network/ports` isolator recovery by starting > a task that is listening on a rogue port. We only configure the > isolator when we restart the agent to simulate the case where a > task only starts to misbehave after an agent recovery. > > > Diffs > ----- > > src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/60593/diff/11/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
