> On Aug. 23, 2017, 7:58 a.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 80 (patched) > > <https://reviews.apache.org/r/60765/diff/10/?file=1801027#file1801027line80> > > > > Why do we need a template function?
We need this to be ablt to use the same code for the `v1` API. > On Aug. 23, 2017, 7:58 a.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 85 (patched) > > <https://reviews.apache.org/r/60765/diff/10/?file=1801027#file1801027line85> > > > > Can we just do `set_type(HealthCheck::TCP)`? We have to deal with the old and new APIs, so this can be `mesos::HealthCheck::TCP` or `mesos::v1::HealthCheck::TCP`. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60765/#review183314 ----------------------------------------------------------- On July 29, 2017, 12:02 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60765/ > ----------------------------------------------------------- > > (Updated July 29, 2017, 12:02 a.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Added tests to verify that the `network/ports` is able to correctly > terminate only tasks that use rogue TCP ports. > > > Diffs > ----- > > src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/60765/diff/10/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
