> On Aug. 17, 2017, 2:45 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 148-150 (patched) > > <https://reviews.apache.org/r/60496/diff/10/?file=1797108#file1797108line148> > > > > It seems we only care about `port`, so it might not be needed to > > construct this oject. What about just using > > `ntohs(socketInfo.sourcePort.get())` in the code below? > > James Peach wrote: > I think we should keep the full address. There's no performance impact > and it is helpful for code clarity and debugging.
Dropping this; let's talk further if you disagree :) - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review182691 ----------------------------------------------------------- On Sept. 8, 2017, 12:09 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60496/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2017, 12:09 a.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Implemented ports resource restrictions in the network ports isolator. > Periodically, scan for listening sockets and match them up to all > the open sockets in the containers we are tracking in the network. > Check any sockets we find against the ports resource and trigger a > resource limitation if the port has not been allocated. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/60496/diff/18/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
