----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62286/#review186084 -----------------------------------------------------------
src/log/recover.cpp Lines 652 (patched) <https://reviews.apache.org/r/62286/#comment262513> Putting this in `recover.cpp|hpp` is very wierd. I am leaning towards moving this too `catchup.hpp|cpp` and just overload `catchup` method (without positions). src/log/recover.cpp Lines 701 (patched) <https://reviews.apache.org/r/62286/#comment262510> Any reason not returnning a failure in this case? src/log/recover.cpp Lines 711 (patched) <https://reviews.apache.org/r/62286/#comment262512> Can you add a few comments on this. THis is a bit hacky because we can essentially hijacting the recovery protocol. Ideally, we probably should split the recovery into several phases and uses on the phase that's relevant to this. src/log/recover.cpp Lines 730 (patched) <https://reviews.apache.org/r/62286/#comment262511> Can you explain why we need to recover the same `begin` after a restart? - Jie Yu On Sept. 13, 2017, 4:40 p.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62286/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2017, 4:40 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-7973 > https://issues.apache.org/jira/browse/MESOS-7973 > > > Repository: mesos > > > Description > ------- > > The process is used to "recover" a non-leading VOTING replica by running > the recovery protocol to find current begin and end positions of the log > and catching-up positions that are missing on the replica. This allows > following replicas to serve eventually consistent reads. > > > Diffs > ----- > > src/log/recover.hpp 94d6bb283ea82df607fcc72de05cda3b12ad5d2d > src/log/recover.cpp b366818767adb259ee6805f9978fd330b790a264 > src/tests/log_tests.cpp f9f9400c901152779ae0ebfe74cf8f7aac1d3396 > > > Diff: https://reviews.apache.org/r/62286/diff/1/ > > > Testing > ------- > > Added tests that verify that the new recovery process correctly performs and > produces meaningful result under various circumstances (recovered positions > were truncated, replica was lagging far behind). Ran `make check`. > > > Thanks, > > Ilya Pronin > >
