----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review186855 -----------------------------------------------------------
support/packaging/Jenkinsfile Lines 26-49 (patched) <https://reviews.apache.org/r/62616/#comment263696> Is there a way to have a script in the `support/` directory so that I can build an RPM by just typing `support/packaging/centos7/build_rpm.sh` on my OSX host? And CI script can simply call that. support/packaging/centos/6/Dockerfile Lines 5 (patched) <https://reviews.apache.org/r/62616/#comment263694> This is more like dev packages (used for development and building Mesos). I think we probably need to types of Docker images: 1) dev image like you have here 2) images that are used for running Mesos For 2), we don't need to pull in dependencies for building Mesos. We only need the dependencies for running Mesos. And that dependencies will be included automatically by RPM. So the Dockerfile can be as simple as a single yum install. support/packaging/centos/6/Dockerfile Lines 8 (patched) <https://reviews.apache.org/r/62616/#comment263695> I think to reduce the size of the Docker image, we should probably have less `RUN` directives because each `RUN` will cause Docker daemon to produce a layer. - Jie Yu On Sept. 27, 2017, 9:50 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62616/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2017, 9:50 p.m.) > > > Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7982 > https://issues.apache.org/jira/browse/MESOS-7982 > > > Repository: mesos > > > Description > ------- > > Binary packaging for Centos 7. > > > Diffs > ----- > > support/packaging/Jenkinsfile PRE-CREATION > support/packaging/centos/6/Dockerfile PRE-CREATION > support/packaging/centos/6/mesos.spec PRE-CREATION > support/packaging/centos/7/Dockerfile PRE-CREATION > support/packaging/centos/7/mesos.spec PRE-CREATION > support/packaging/common/mesos PRE-CREATION > support/packaging/common/mesos-init-wrapper PRE-CREATION > support/packaging/common/mesos-master PRE-CREATION > support/packaging/common/mesos-master.service PRE-CREATION > support/packaging/common/mesos-master.upstart PRE-CREATION > support/packaging/common/mesos-slave PRE-CREATION > support/packaging/common/mesos-slave.service PRE-CREATION > support/packaging/common/mesos-slave.upstart PRE-CREATION > > > Diff: https://reviews.apache.org/r/62616/diff/2/ > > > Testing > ------- > > The scripts have been tested on an internal Jenkins CI. A buildjob on ASF > Jenkins CI is available at > https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. > > > Thanks, > > Kapil Arya > >
