> On Oct. 2, 2017, 1:17 p.m., Jie Yu wrote:
> >

Thanks for the comments, Jie! The updated scripts allow for building from a 
local tree from a command line. I'd add a README shortly.


> On Oct. 2, 2017, 1:17 p.m., Jie Yu wrote:
> > support/packaging/centos/6/Dockerfile
> > Lines 5 (patched)
> > <https://reviews.apache.org/r/62616/diff/2/?file=1837905#file1837905line5>
> >
> >     This is more like dev packages (used for development and building 
> > Mesos).
> >     
> >     I think we probably need to types of Docker images:
> >     1) dev image like you have here
> >     2) images that are used for running Mesos
> >     
> >     For 2), we don't need to pull in dependencies for building Mesos. We 
> > only need the dependencies for running Mesos. And that dependencies will be 
> > included automatically by RPM. So the Dockerfile can be as simple as a 
> > single yum install.

These docker images are for building rpms only. Once the RPM is there, we can 
just have a simple docker file that adds the repo and install the rpm package 
inside it. But I think that is stage 2 and orthogonal to this RR.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review186855
-----------------------------------------------------------


On Oct. 13, 2017, 2:02 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2017, 2:02 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7982
>     https://issues.apache.org/jira/browse/MESOS-7982
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Binary packaging for Centos 7.
> 
> 
> Diffs
> -----
> 
>   support/packaging/Jenkinsfile PRE-CREATION 
>   support/packaging/centos/build_rpm.sh PRE-CREATION 
>   support/packaging/centos/centos6.dockerfile PRE-CREATION 
>   support/packaging/centos/centos7.dockerfile PRE-CREATION 
>   support/packaging/centos/mesos.spec PRE-CREATION 
>   support/packaging/common/mesos PRE-CREATION 
>   support/packaging/common/mesos-init-wrapper PRE-CREATION 
>   support/packaging/common/mesos-master PRE-CREATION 
>   support/packaging/common/mesos-master.service PRE-CREATION 
>   support/packaging/common/mesos-master.upstart PRE-CREATION 
>   support/packaging/common/mesos-slave PRE-CREATION 
>   support/packaging/common/mesos-slave.service PRE-CREATION 
>   support/packaging/common/mesos-slave.upstart PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62616/diff/3/
> 
> 
> Testing
> -------
> 
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF 
> Jenkins CI is available at 
> https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Reply via email to