> On Oct. 3, 2017, 12:57 p.m., James Peach wrote: > > support/packaging/centos/7/mesos.spec > > Lines 33 (patched) > > <https://reviews.apache.org/r/62616/diff/2/?file=1837908#file1837908line33> > > > > Handling the SVN dependency is a bit quirky. If you do what you have > > done here, you end up building against a more recent libsubversion than the > > one available in the distribution. Everything will appear to work due to > > lazy symbol binding, but (I think) that Aurora users will use the registry > > diff APIs that will trigger binding for the missing symbols.
I have modified it to specify a version. Do you think it's acceptable now? - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review186971 ----------------------------------------------------------- On Oct. 13, 2017, 2:02 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62616/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2017, 2:02 p.m.) > > > Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7982 > https://issues.apache.org/jira/browse/MESOS-7982 > > > Repository: mesos > > > Description > ------- > > Binary packaging for Centos 7. > > > Diffs > ----- > > support/packaging/Jenkinsfile PRE-CREATION > support/packaging/centos/build_rpm.sh PRE-CREATION > support/packaging/centos/centos6.dockerfile PRE-CREATION > support/packaging/centos/centos7.dockerfile PRE-CREATION > support/packaging/centos/mesos.spec PRE-CREATION > support/packaging/common/mesos PRE-CREATION > support/packaging/common/mesos-init-wrapper PRE-CREATION > support/packaging/common/mesos-master PRE-CREATION > support/packaging/common/mesos-master.service PRE-CREATION > support/packaging/common/mesos-master.upstart PRE-CREATION > support/packaging/common/mesos-slave PRE-CREATION > support/packaging/common/mesos-slave.service PRE-CREATION > support/packaging/common/mesos-slave.upstart PRE-CREATION > > > Diff: https://reviews.apache.org/r/62616/diff/3/ > > > Testing > ------- > > The scripts have been tested on an internal Jenkins CI. A buildjob on ASF > Jenkins CI is available at > https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. > > > Thanks, > > Kapil Arya > >