----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/#review188764 -----------------------------------------------------------
Ship it! src/launcher/fetcher.cpp Lines 99 (patched) <https://reviews.apache.org/r/60628/#comment265775> Nit: // __WINDOWS__ - Andrew Schwartzmeyer On Oct. 19, 2017, 11:18 a.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60628/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2017, 11:18 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Tests for tar, gzip, and such won't be working on Windows for > the time being. Thoughts are to provide this capability to the > Fetcher in a cross-platform manner via a programmatic code library > rather than Linux-specific command line tools (tar, gzip, etc). > See MESOS-8064 for more details. > > In the short term, zip and unzip will work since PowerShell can > support that natively. > > > Diffs > ----- > > src/launcher/CMakeLists.txt c7a83d476efe13d65fa529e7676b6488eb48f44b > src/launcher/fetcher.cpp 5a9e93adbf2e4f0b8ff64a69e62fea5f6a0b8f2d > src/slave/containerizer/fetcher.cpp > ba5b0979aa427c5b3dbacf39661d6027da13e0d6 > src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 > src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 > > > Diff: https://reviews.apache.org/r/60628/diff/5/ > > > Testing > ------- > > See upstream. > > > Thanks, > > Jeff Coffler > >
