-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63341/
-----------------------------------------------------------

(Updated Nov. 6, 2017, 10:34 a.m.)


Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Michael 
Park.


Changes
-------

Added guard to avoid having to always define `BUILD_JAVA_JVM_LIBRARY`.


Bugs: MESOS-5455
    https://issues.apache.org/jira/browse/MESOS-5455


Repository: mesos


Description
-------

This resolves MESOS-5455, and consolidates the `BUILD` variables into
one location.


Diffs (updated)
-----

  cmake/CompilationConfigure.cmake deb574200bceb605a60b536a396c98d9247c6018 
  src/CMakeLists.txt b0e223121f24ac0dc604dc2c639158b817eec535 
  src/common/build.cpp 4192b89cbee1c9d7a75213f55b189565cd8a10f1 
  src/common/build_config.hpp.in ac7059ab2aa54011197b9e1a46f9d7fd39ac39c6 


Diff: https://reviews.apache.org/r/63341/diff/3/

Changes: https://reviews.apache.org/r/63341/diff/2-3/


Testing
-------

Checked the emitted `build_config.hpp` under various conditions; flags are set 
correctly (and can still build of course).


Thanks,

Andrew Schwartzmeyer

Reply via email to