----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63341/#review192766 -----------------------------------------------------------
Ship it! Ship It! - Joseph Wu On Dec. 4, 2017, 1:19 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63341/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2017, 1:19 p.m.) > > > Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, > Joseph Wu, and Michael Park. > > > Bugs: MESOS-5455 > https://issues.apache.org/jira/browse/MESOS-5455 > > > Repository: mesos > > > Description > ------- > > This resolves MESOS-5455, and consolidates the `BUILD` variables into > one location. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake deb574200bceb605a60b536a396c98d9247c6018 > src/CMakeLists.txt 592489df070a0c4fdee814a4a7b613e62a544f88 > src/common/build.cpp 4192b89cbee1c9d7a75213f55b189565cd8a10f1 > src/common/build_config.hpp.in ac7059ab2aa54011197b9e1a46f9d7fd39ac39c6 > > > Diff: https://reviews.apache.org/r/63341/diff/4/ > > > Testing > ------- > > Checked the emitted `build_config.hpp` under various conditions; flags are > set correctly (and can still build of course). > > > Thanks, > > Andrew Schwartzmeyer > >
