----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63642/#review190371 -----------------------------------------------------------
src/tests/master_validation_tests.cpp Lines 4215 (patched) <https://reviews.apache.org/r/63642/#comment267704> 2 space indentation. src/tests/master_validation_tests.cpp Lines 4225-4226 (patched) <https://reviews.apache.org/r/63642/#comment267705> Nit: I feel the grouping looks clearer to have: ``` frameworks.push_back(DEFAULT_FRAMEWORK_INFO); frameworks[0].set_name("framework1"); frameworks[0].mutable_id()->set_value("framework1"); frameworks.push_back(DEFAULT_FRAMEWORK_INFO); frameworks[1].set_name("framework2"); frameworks[1].mutable_id()->set_value("framework2"); ``` BTW you could use `back()` as well. Same for the executors. Up to you. src/tests/master_validation_tests.cpp Lines 4241-4242 (patched) <https://reviews.apache.org/r/63642/#comment267726> These are `ASSERT_*`s? Same below. src/tests/master_validation_tests.cpp Lines 4243 (patched) <https://reviews.apache.org/r/63642/#comment267727> These are `EXPECT_*`? Same below. - Jiang Yan Xu On Nov. 7, 2017, 10:47 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63642/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2017, 10:47 a.m.) > > > Review request for mesos, James DeFelice and Jiang Yan Xu. > > > Bugs: MESOS-8169 > https://issues.apache.org/jira/browse/MESOS-8169 > > > Repository: mesos > > > Description > ------- > > Added a test to ensure that the ReregisterSlaveMessage validation > correctly allows duplicate ExecutorIDs as long as they are scoped > to different frameworks. > > > Diffs > ----- > > src/tests/master_validation_tests.cpp > be8c8920fdd6eb72fc77247844a731070db5fa1c > > > Diff: https://reviews.apache.org/r/63642/diff/3/ > > > Testing > ------- > > make check (Fedora 26) with PR #248 applied. > > > Thanks, > > James Peach > >
