----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63642/#review190408 -----------------------------------------------------------
Fix it, then Ship it! src/tests/master_validation_tests.cpp Lines 4240-4241 (patched) <https://reviews.apache.org/r/63642/#comment267733> I was suggesting `ASSERT_*` as strictly speaking the test code prepared these, not the code to be tested so it should always succeed otherwise we should abort the test. Here and below. - Jiang Yan Xu On Nov. 7, 2017, 10:47 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63642/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2017, 10:47 a.m.) > > > Review request for mesos, James DeFelice and Jiang Yan Xu. > > > Bugs: MESOS-8169 > https://issues.apache.org/jira/browse/MESOS-8169 > > > Repository: mesos > > > Description > ------- > > Added a test to ensure that the ReregisterSlaveMessage validation > correctly allows duplicate ExecutorIDs as long as they are scoped > to different frameworks. > > > Diffs > ----- > > src/tests/master_validation_tests.cpp > be8c8920fdd6eb72fc77247844a731070db5fa1c > > > Diff: https://reviews.apache.org/r/63642/diff/4/ > > > Testing > ------- > > make check (Fedora 26) with PR #248 applied. > > > Thanks, > > James Peach > >
