----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63625/#review190686 -----------------------------------------------------------
src/tests/resource_provider_manager_tests.cpp Lines 687 (patched) <https://reviews.apache.org/r/63625/#comment268279> The agent will send two `UpdateSlaveMessage`, one once it has registered, and another one after the resource provider has added its resources. That means we might await the wrong `UpdateSlaveMessage` below. I'd suggest to wait for an `UpdateSlaveMessage` here instead of waiting for `__recover`. This should remove the race below. - Benjamin Bannier On Nov. 8, 2017, 6:56 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63625/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2017, 6:56 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added a test for resource conversion using a resource provider. > > > Diffs > ----- > > src/tests/resource_provider_manager_tests.cpp > 4008b1c751d6227b99adef756e95174d7d8a62f2 > > > Diff: https://reviews.apache.org/r/63625/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
