----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63625/#review190751 -----------------------------------------------------------
Fix it, then Ship it! src/tests/resource_provider_manager_tests.cpp Lines 658 (patched) <https://reviews.apache.org/r/63625/#comment268362> kill this line src/tests/resource_provider_manager_tests.cpp Lines 659 (patched) <https://reviews.apache.org/r/63625/#comment268363> s/flags/masterFlags/ src/tests/resource_provider_manager_tests.cpp Lines 759 (patched) <https://reviews.apache.org/r/63625/#comment268367> kill this line. src/tests/resource_provider_manager_tests.cpp Lines 800 (patched) <https://reviews.apache.org/r/63625/#comment268368> kill src/tests/resource_provider_manager_tests.cpp Lines 809 (patched) <https://reviews.apache.org/r/63625/#comment268369> kill src/tests/resource_provider_manager_tests.cpp Lines 851 (patched) <https://reviews.apache.org/r/63625/#comment268370> kill - Jie Yu On Nov. 10, 2017, 3:19 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63625/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2017, 3:19 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added a test for resource conversion using a resource provider. > > > Diffs > ----- > > src/tests/resource_provider_manager_tests.cpp > 4008b1c751d6227b99adef756e95174d7d8a62f2 > > > Diff: https://reviews.apache.org/r/63625/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
