-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62145/
-----------------------------------------------------------
(Updated Nov. 13, 2017, 5:32 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
* Changed AuthZ to use the AuthorizationAcceptor pattern.
* Removed the `user` fields from AuthZ objects due to decision to reduce
granularity of AuthZ.
* Combined `__launchContainer` into `_launchContainer`.
* Made failure to chown standalone sandbox into a 500 error.
Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305
Repository: mesos
Description
-------
The Standalone and Nested Container APIs are very similar.
This commit combines the two API implementations by adding a
translation function (i.e. `launchNestedContainer` and
`launchContainer`) which unpacks the V1 protobuf into fields
which can be passed into a common function (i.e. `_launchContainer`).
The common functions authorize based on the type of container being
launched and it is possible to use both Standalone and Nested
Container APIs interchangably for nested containers.
This approach is somewhat messy for for the `WAIT_(NESTED_)CONTAINER`
calls, as these methods require different return protobufs based on
the original call.
Diffs (updated)
-----
src/slave/http.hpp 44a95dec4c9b8bb65d712c5538bbd7afffe2cf7b
src/slave/http.cpp 22cdac97e1a8a28ca149043ffa1d0646073d7fdb
Diff: https://reviews.apache.org/r/62145/diff/5/
Changes: https://reviews.apache.org/r/62145/diff/4-5/
Testing
-------
See later in chain.
Thanks,
Joseph Wu
