----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63019/#review191132 -----------------------------------------------------------
src/csi/client.cpp Lines 34-49 (patched) <https://reviews.apache.org/r/63019/#comment268743> Can you add a comment explaining why these are recoverable? And how to recover from them (or a TODO if that has yet to be implemented). - Joseph Wu On Oct. 16, 2017, 5:37 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63019/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2017, 5:37 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > By implementing the validation logic and error handling in > `mesos::csi::Client`, the implementation of the storage local resource > provider could be cleaner. In the furute, we could also implement the > retry logic here. > > > Diffs > ----- > > src/Makefile.am b60a54a031260de6f1fb43584ae5083df2dc7e31 > src/csi/client.cpp e171f030efedc60521053399055d67bf99d3fcd2 > src/tests/mock_csi_plugin.hpp b7926c4b4ca980e37131c3e9b227343e80f5c002 > src/tests/mock_csi_plugin.cpp 46ca398e48578537393e4050c3a9920b367b8946 > > > Diff: https://reviews.apache.org/r/63019/diff/3/ > > > Testing > ------- > > make test > > > Thanks, > > Chun-Hung Hsiao > >
