----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63104/#review188660 -----------------------------------------------------------
Fix it, then Ship it! This helper seems generally useful. Could we please resurrect this patch @nfnt? src/common/protobuf_utils.cpp Lines 757-758 (patched) <https://reviews.apache.org/r/63104/#comment265681> Let's not use a `default` case and pull the `UNREACHABLE` out of the `switch`, see https://issues.apache.org/jira/browse/MESOS-3754. - Benjamin Bannier On Oct. 20, 2017, 2:50 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63104/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2017, 2:50 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-7594 > https://issues.apache.org/jira/browse/MESOS-7594 > > > Repository: mesos > > > Description > ------- > > Added a helper to extract resources from storage operations. > > > Diffs > ----- > > src/common/protobuf_utils.hpp c43ab75b5492320dfe19a7c723a72ac52b8ab722 > src/common/protobuf_utils.cpp fd4858a64dfc136dd03cb1eef4c97d0f8d43bdae > > > Diff: https://reviews.apache.org/r/63104/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
