-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63953/
-----------------------------------------------------------

(Updated Nov. 21, 2017, 1:12 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
-------

Added comment.


Bugs: MESOS-7361
    https://issues.apache.org/jira/browse/MESOS-7361


Repository: mesos


Description (updated)
-------

This change enables filtering when printing logs regarding
containers. If its class is `DEBUG` we print the log line at a
verbose level 1 otherwise we print is at the `INFO` level.

We use the added macro in containerizer.cpp so that COMMAND health
checks cause less INFO logs (15 instead of 26 before).


Diffs (updated)
-----

  src/Makefile.am 49dec55ced32945ad0414c32eb4e00247f4b54f2 
  src/logging/utils.hpp PRE-CREATION 
  src/slave/containerizer/mesos/containerizer.cpp 
db5f044f7415386c94e4930f365dfc14d403414a 


Diff: https://reviews.apache.org/r/63953/diff/2/

Changes: https://reviews.apache.org/r/63953/diff/1-2/


Testing
-------

Started a Mesos cluster and used `mesos-execute` with this task group to check 
that the behaviour after this patch was the one expected:

```
{
  "tasks": [
    {
      "name": "Name of the task",
      "task_id": {
        "value": "task-group"
      },
      "agent_id": {
        "value": ""
      },
      "resources": [
        {
          "name": "cpus",
          "type": "SCALAR",
          "scalar": {
            "value": 0.01
          }
        },
        {
          "name": "mem",
          "type": "SCALAR",
          "scalar": {
            "value": 2
          }
        }
      ],
      "command": {
        "value": "sleep 1000"
      },
      "check": {
        "type": "COMMAND",
        "command": {
          "command": {
            "value": "echo \"Bonjour\""
          },
          "uris": []
        }
      }
    }
  ]
}
```

And:
```
$ nice make check
```


Thanks,

Armand Grillet

Reply via email to