----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63953/#review191577 -----------------------------------------------------------
FAIL: Mesos tests failed to build. Reviews applied: `['63953']` Failed command: `cmake.exe --build . --target mesos-tests --config Debug` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63953 Relevant logs: - [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63953/logs/mesos-tests-build-cmake-stdout.log): ``` C:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(242): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(274): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\master/master.hpp(2112): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\DCOS\mesos\mesos\src\common\protobuf_utils.cpp) [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\files\files.cpp(703): warning C4267: 'argument': conversion from 'size_t' to 'off_t', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\master/master.hpp(2112): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\DCOS\mesos\mesos\src\master\master.cpp) [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\master\master.cpp(6173): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\master\master.cpp(6264): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\master\master.cpp(6858): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\master\master.cpp(8386): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\master\master.cpp(10220): warning C4244: 'return': conversion from '::size_t' to 'double', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\master/master.hpp(2112): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\DCOS\mesos\mesos\src\master\quota_handler.cpp) [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\master/master.hpp(2112): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file C:\DCOS\mesos\mesos\src\master\weights_handler.cpp) [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\master\allocator\sorter\drf\sorter.cpp(589): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\slave/containerizer/mesos/isolators/posix.hpp(55): warning C4244: 'argument': conversion from 'google::protobuf::uint64' to 'const pid_t', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(762): warning C4244: 'argument': conversion from 'google::protobuf::uint64' to 'pid_t', possible loss of data [C:\DCOS\mesos\src\mesos.vcxproj] "C:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) -> "C:\DCOS\mesos\src\mesos.vcxproj" (default target) (12) -> (ClCompile target) -> C:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(2326): error C2039: 'container_class': is not a member of 'Option<mesos::slave::ContainerConfig>' [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(2616): error C2039: 'container_class': is not a member of 'Option<mesos::slave::ContainerConfig>' [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(2781): error C2039: 'container_class': is not a member of 'Option<mesos::slave::ContainerConfig>' [C:\DCOS\mesos\src\mesos.vcxproj] C:\DCOS\mesos\mesos\src\slave\containerizer\mesos\containerizer.cpp(2927): error C2440: 'initializing': cannot convert from 'Option<mesos::slave::ContainerConfig>' to 'mesos::slave::ContainerConfig' [C:\DCOS\mesos\src\mesos.vcxproj] 137 Warning(s) 4 Error(s) Time Elapsed 00:24:18.20 ``` - [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63953/logs/mesos-tests-CMakeOutput.log): ``` Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\". Creating directory "cmTC_d4561.dir\Debug\cmTC_d4561.tlog\". InitializeBuildStatus: Creating "cmTC_d4561.dir\Debug\cmTC_d4561.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified. ClCompile: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_d4561.dir\Debug\" /Fd"cmTC_d4561.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64 Copyright (C) Microsoft Corporation. All rights reserved. cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_d4561.dir\Debug\" /Fd"cmTC_d4561.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx src.cxx Link: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_d4561.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_d4561.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_d4561.lib" /MACHINE:X64 /machine:x64 cmTC_d4561.dir\Debug\src.obj cmTC_d4561.vcxproj -> C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_d4561.exe cmTC_d4561.vcxproj -> C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_d4561.pdb (Full PDB) FinalizeBuildStatus: Deleting file "cmTC_d4561.dir\Debug\cmTC_d4561.tlog\unsuccessfulbuild". Touching "cmTC_d4561.dir\Debug\cmTC_d4561.tlog\cmTC_d4561.lastbuildstate". Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_d4561.vcxproj" (default targets). Build succeeded. 0 Warning(s) 0 Error(s) Time Elapsed 00:00:01.80 Source file was: int main() { return 0; } ``` - [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63953/logs/mesos-tests-CMakeError.log): ``` PrepareForBuild: Creating directory "cmTC_431bc.dir\Debug\". Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\". Creating directory "cmTC_431bc.dir\Debug\cmTC_431bc.tlog\". InitializeBuildStatus: Creating "cmTC_431bc.dir\Debug\cmTC_431bc.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified. ClCompile: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_431bc.dir\Debug\" /Fd"cmTC_431bc.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64 Copyright (C) Microsoft Corporation. All rights reserved. cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_431bc.dir\Debug\" /Fd"cmTC_431bc.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c CheckIncludeFile.c C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_431bc.vcxproj] Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_431bc.vcxproj" (default targets) -- FAILED. Build FAILED. "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_431bc.vcxproj" (default target) (1) -> (ClCompile target) -> C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_431bc.vcxproj] 0 Warning(s) 1 Error(s) Time Elapsed 00:00:01.16 ``` - Mesos Reviewbot Windows On Nov. 21, 2017, 1:12 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63953/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 1:12 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-7361 > https://issues.apache.org/jira/browse/MESOS-7361 > > > Repository: mesos > > > Description > ------- > > This change enables filtering when printing logs regarding > containers. If its class is `DEBUG` we print the log line at a > verbose level 1 otherwise we print is at the `INFO` level. > > We use the added macro in containerizer.cpp so that COMMAND health > checks cause less INFO logs (15 instead of 26 before). > > > Diffs > ----- > > src/Makefile.am 49dec55ced32945ad0414c32eb4e00247f4b54f2 > src/logging/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp > db5f044f7415386c94e4930f365dfc14d403414a > > > Diff: https://reviews.apache.org/r/63953/diff/3/ > > > Testing > ------- > > Started a Mesos cluster and used `mesos-execute` with this task group to > check that the behaviour after this patch was the one expected: > > ``` > { > "tasks": [ > { > "name": "Name of the task", > "task_id": { > "value": "task-group" > }, > "agent_id": { > "value": "" > }, > "resources": [ > { > "name": "cpus", > "type": "SCALAR", > "scalar": { > "value": 0.01 > } > }, > { > "name": "mem", > "type": "SCALAR", > "scalar": { > "value": 2 > } > } > ], > "command": { > "value": "sleep 1000" > }, > "check": { > "type": "COMMAND", > "command": { > "command": { > "value": "echo \"Bonjour\"" > }, > "uris": [] > } > } > } > ] > } > ``` > > And: > ``` > $ nice make check > ``` > > > Thanks, > > Armand Grillet > >
