> On Nov. 24, 2017, 1:07 p.m., Andrei Budnik wrote: > > src/docker/executor.cpp > > Lines 386 (patched) > > <https://reviews.apache.org/r/64033/diff/1/?file=1900085#file1900085line386> > > > > Consider moving this check to [the > > driver](https://github.com/apache/mesos/blob/708902d6f207b6f93c94b3589a31d54c812a7657/src/exec/exec.cpp#L343).
This is a very good suggestion. First off, this way we guarantee that all driver-based executors behave properly in this case. Second, behaviour of the command executor in the HTTP mode is not affected, which is a good thing. And third, if the `killTask` message is not delivered to the executor (for example, due to V0-V1 executor adapter holding off messages until `registered` is received), the executor will eventually shutdown. I will update the patch in a while. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/#review191835 ----------------------------------------------------------- On Nov. 22, 2017, 5:05 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64033/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2017, 5:05 p.m.) > > > Review request for mesos, Andrei Budnik, Armand Grillet, and Vinod Kone. > > > Bugs: MESOS-8247 > https://issues.apache.org/jira/browse/MESOS-8247 > > > Repository: mesos > > > Description > ------- > > `ExecutorRegisteredMessage` or `RunTaskMessage` may not be delivered > to a driver-based executor. Since these messages are not retried, > the executor will never start a task and will remain idle, ignoring > kill task request. This patch shutdown driver-based executors if kill > task arrives before the task has been started. > > > Diffs > ----- > > src/docker/executor.cpp 3974f20052e3c12eb154a5146d19d4dc1759859f > src/launcher/executor.cpp c688c04e598ac140421fd5e47359b0e48d30bcc5 > > > Diff: https://reviews.apache.org/r/64033/diff/1/ > > > Testing > ------- > > make check on MacOS 10.11.6 > > > Thanks, > > Alexander Rukletsov > >
