> On Nov. 22, 2017, 5:44 p.m., Vinod Kone wrote: > > can you write tests please?
Writing a test here is not trivial. We don't have infrastructure in place to "hook" to our executors. All built-in executors are implemented in ".cpp" files, which does not allow to create an instance of executor process in a test and, for example, drop specific calls. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/#review191748 ----------------------------------------------------------- On Nov. 22, 2017, 5:05 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64033/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2017, 5:05 p.m.) > > > Review request for mesos, Andrei Budnik, Armand Grillet, and Vinod Kone. > > > Bugs: MESOS-8247 > https://issues.apache.org/jira/browse/MESOS-8247 > > > Repository: mesos > > > Description > ------- > > `ExecutorRegisteredMessage` or `RunTaskMessage` may not be delivered > to a driver-based executor. Since these messages are not retried, > the executor will never start a task and will remain idle, ignoring > kill task request. This patch shutdown driver-based executors if kill > task arrives before the task has been started. > > > Diffs > ----- > > src/docker/executor.cpp 3974f20052e3c12eb154a5146d19d4dc1759859f > src/launcher/executor.cpp c688c04e598ac140421fd5e47359b0e48d30bcc5 > > > Diff: https://reviews.apache.org/r/64033/diff/1/ > > > Testing > ------- > > make check on MacOS 10.11.6 > > > Thanks, > > Alexander Rukletsov > >
