----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/#review191843 -----------------------------------------------------------
src/exec/exec.cpp Lines 355 (patched) <https://reviews.apache.org/r/64033/#comment269780> What if `killTask` received after task completion and [acknowledgement](https://github.com/apache/mesos/blob/708902d6f207b6f93c94b3589a31d54c812a7657/src/exec/exec.cpp#L396)? Maybe we should just update the log message to cover all possible states of the driver (including one I mentioned above). Also, it would be helpful to have 2 different checks and 2 different log messages to distinguish each case. - Andrei Budnik On Nov. 24, 2017, 8:14 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64033/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2017, 8:14 p.m.) > > > Review request for mesos, Andrei Budnik, Armand Grillet, and Vinod Kone. > > > Bugs: MESOS-8247 > https://issues.apache.org/jira/browse/MESOS-8247 > > > Repository: mesos > > > Description > ------- > > `ExecutorRegisteredMessage` or `RunTaskMessage` may not be delivered > to a driver-based executor. Since these messages are not retried, > without this patch an executor never starts a task and remains idle, > ignoring kill task request. This patch ensures all driver-based > executors eventually shut down if kill task arrives before the task > has been started. > > > Diffs > ----- > > src/docker/executor.cpp 3974f20052e3c12eb154a5146d19d4dc1759859f > src/exec/exec.cpp cdbf149a9047ddad6beef64be1266e15e7643afc > src/launcher/executor.cpp c688c04e598ac140421fd5e47359b0e48d30bcc5 > > > Diff: https://reviews.apache.org/r/64033/diff/3/ > > > Testing > ------- > > make check on MacOS 10.11.6 > > Manual testing using modified "exec.cpp" that drops executor registration > confirmation. > > > Thanks, > > Alexander Rukletsov > >
