----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63385/#review191845 -----------------------------------------------------------
src/csi/utils.hpp Lines 36-43 (patched) <https://reviews.apache.org/r/63385/#comment269781> Can you explain to me why you need the equality check for GetPluginInfoResponse? src/csi/utils.hpp Lines 99 (patched) <https://reviews.apache.org/r/63385/#comment269782> We don't do typedef, especially in header. Also, I feel this is a general protobuf util helper. We should put it under src/common/protobuf_utils.hpp|cpp ``` convertMapsToLabels(...) convertLabelsToMaps(...) ``` - Jie Yu On Nov. 22, 2017, 5:21 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63385/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2017, 5:21 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added utility functions for CSI Plugin info and volume attributes. > > > Diffs > ----- > > src/csi/utils.hpp PRE-CREATION > src/csi/utils.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/63385/diff/2/ > > > Testing > ------- > > make > > > Thanks, > > Chun-Hung Hsiao > >
