> On Nov. 24, 2017, 11:49 p.m., Jie Yu wrote: > > src/csi/utils.hpp > > Lines 36-43 (patched) > > <https://reviews.apache.org/r/63385/diff/2/?file=1899465#file1899465line36> > > > > Can you explain to me why you need the equality check for > > GetPluginInfoResponse?
For checking if the controller plugin component and the node plugin component are consistent. > On Nov. 24, 2017, 11:49 p.m., Jie Yu wrote: > > src/csi/utils.hpp > > Lines 99 (patched) > > <https://reviews.apache.org/r/63385/diff/2/?file=1899465#file1899465line99> > > > > We don't do typedef, especially in header. > > > > Also, I feel this is a general protobuf util helper. We should put it > > under src/common/protobuf_utils.hpp|cpp > > > > ``` > > convertMapsToLabels(...) > > convertLabelsToMaps(...) > > ``` I originally put the functions here because it's used for converting a proto3 string-to-string map field to our proto2 `Labels`. But there should be no difference for `google::protobuf::Map` to handle proto2 and proto3 maps, and thus it should be safe to use these functions to handle both proto2 and proto3 maps. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63385/#review191845 ----------------------------------------------------------- On Nov. 22, 2017, 5:21 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63385/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2017, 5:21 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added utility functions for CSI Plugin info and volume attributes. > > > Diffs > ----- > > src/csi/utils.hpp PRE-CREATION > src/csi/utils.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/63385/diff/2/ > > > Testing > ------- > > make > > > Thanks, > > Chun-Hung Hsiao > >
