> On Nov. 25, 2017, 7:49 p.m., Avinash sridharan wrote: > > src/checks/tcp_connect.cpp > > Lines 88 (patched) > > <https://reviews.apache.org/r/63795/diff/4/?file=1900074#file1900074line94> > > > > Why do we need this? `net::IP` will always be `AF_INET` or `AF_INET6`?
That's from Alex's comment (https://reviews.apache.org/r/63795/#comment268744), I think it is because we do not want to be tightly coupled with the internal implementation of `net::IP::parse()`. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/#review191849 ----------------------------------------------------------- On Nov. 22, 2017, 11:14 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63795/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2017, 11:14 p.m.) > > > Review request for mesos, Alexander Rukletsov and Avinash sridharan. > > > Bugs: MESOS-8050 > https://issues.apache.org/jira/browse/MESOS-8050 > > > Repository: mesos > > > Description > ------- > > Made `mesos-tcp-connect` support IPv6. > > > Diffs > ----- > > src/checks/tcp_connect.cpp 2514f4aebcc634b18cd2b3c36529222fe456e903 > > > Diff: https://reviews.apache.org/r/63795/diff/4/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
