> On Nov. 25, 2017, 11:49 a.m., Avinash sridharan wrote: > > src/checks/tcp_connect.cpp > > Lines 88 (patched) > > <https://reviews.apache.org/r/63795/diff/4/?file=1900074#file1900074line94> > > > > Why do we need this? `net::IP` will always be `AF_INET` or `AF_INET6`? > > Qian Zhang wrote: > That's from Alex's comment > (https://reviews.apache.org/r/63795/#comment268744), I think it is because we > do not want to be tightly coupled with the internal implementation of > `net::IP::parse()`.
I don't think that comment is valid with the use of `net::IP` and `network::address`. `net::IP` can only be `AF_INET` or AF_INET6`. Its a fundamentatl property of IP addresses. So this check is redundant here. I think we should remove it. https://github.com/apache/mesos/blob/bd5e874c22f0d16fc5494213d319065cf9107d0f/3rdparty/stout/include/stout/ip.hpp#L417 - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/#review191849 ----------------------------------------------------------- On Nov. 22, 2017, 3:14 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63795/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2017, 3:14 p.m.) > > > Review request for mesos, Alexander Rukletsov and Avinash sridharan. > > > Bugs: MESOS-8050 > https://issues.apache.org/jira/browse/MESOS-8050 > > > Repository: mesos > > > Description > ------- > > Made `mesos-tcp-connect` support IPv6. > > > Diffs > ----- > > src/checks/tcp_connect.cpp 2514f4aebcc634b18cd2b3c36529222fe456e903 > > > Diff: https://reviews.apache.org/r/63795/diff/4/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
