> On Dec. 3, 2017, 2:19 p.m., Zhitao Li wrote: > > src/slave/slave.cpp > > Lines 6171-6173 (patched) > > <https://reviews.apache.org/r/64267/diff/1/?file=1906550#file1906550line6171> > > > > I think adding an early return is more readable
can we return? for both cases (no matter trigger gc or not), we need to call `delay()` for the next gc cycle. let's follow the `_checkDiskUsage()`. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64267/#review192652 ----------------------------------------------------------- On Dec. 1, 2017, 5:10 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64267/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2017, 5:10 p.m.) > > > Review request for mesos, Jie Yu, Qian Zhang, Vinod Kone, and Zhitao Li. > > > Bugs: MESOS-8294 > https://issues.apache.org/jira/browse/MESOS-8294 > > > Repository: mesos > > > Description > ------- > > Supported basic auto image gc in the agent. > > > Diffs > ----- > > src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059 > src/slave/slave.cpp a9aa987ade67542b85aeb51356d00a4c14c6be9d > > > Diff: https://reviews.apache.org/r/64267/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
