----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64267/#review193029 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/slave/slave.cpp Line 6170 (original), 6231 (patched) <https://reviews.apache.org/r/64267/#comment271521> I feel that an early return makes the code more readable. - Zhitao Li On Dec. 6, 2017, 7:13 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64267/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2017, 7:13 p.m.) > > > Review request for mesos, Jie Yu, Qian Zhang, Vinod Kone, and Zhitao Li. > > > Bugs: MESOS-8294 > https://issues.apache.org/jira/browse/MESOS-8294 > > > Repository: mesos > > > Description > ------- > > Supported basic auto image gc in the agent. > > > Diffs > ----- > > src/slave/slave.hpp 06afd522ac424faa427366219cb212ee18a81c33 > src/slave/slave.cpp 49270013537356c8fe9150d757b064bc3bbae3cb > > > Diff: https://reviews.apache.org/r/64267/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
