> On Dec. 2, 2017, 12:41 a.m., Megha Sharma wrote: > > src/tests/upgrade_tests.cpp > > Line 138 (original), 138 (patched) > > <https://reviews.apache.org/r/64098/diff/8/?file=1906538#file1906538line138> > > > > Sorry my bad looks like the fix for this test is still needed. I am not > > clear though what do you mean by ignoring the update? As I understand > > setting the expectation is unavoidable coz if we don't then the test fails > > claiming that previously set expectation here is being called more than > > once. > > Megha Sharma wrote: > ^^Ilya > > Ilya Pronin wrote: > Yeah, we'll most likely need to set an expectation, but we can make it > just `WillRepeatedly(Return())` and omit the future, because we don't really > care about that status update in those tests.
This expectation is not needed anymore in the test after using the registry. - Megha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review192607 ----------------------------------------------------------- On Dec. 2, 2017, 12:29 a.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64098/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2017, 12:29 a.m.) > > > Review request for mesos, Ilya Pronin, James Peach, and Jiang Yan Xu. > > > Bugs: MESOS-6406 > https://issues.apache.org/jira/browse/MESOS-6406 > > > Repository: mesos > > > Description > ------- > > Master will send task status updates to frameworks when an agent > which has been previously removed by the master for being unreachable > or is unknown to the master due to the garbage collection of > the unreachable and gone agents in the registry re-registers. > > > Diffs > ----- > > src/master/master.cpp dfe60ef670edcaefa0c1241df2e2870f650fcf9e > src/tests/master_allocator_tests.cpp > 3400d70bb0ba564eac43c4639eee0efd4d8059e6 > src/tests/master_tests.cpp 57eae320a7a398527cd3623c89bf67f319a8e955 > src/tests/partition_tests.cpp 31ebfe1655438eceae74d72a223df03a9dbd282d > src/tests/persistent_volume_tests.cpp > 4aa3c2e8b0f461cd78053707cff8bcb2e6f2b0d7 > src/tests/slave_recovery_tests.cpp f14c6ef69eb20a03454c8197df79b572a3c6d050 > src/tests/upgrade_tests.cpp 7f434dbba858f636719eec24e92b306b76430c4c > > > Diff: https://reviews.apache.org/r/64098/diff/11/ > > > Testing > ------- > > with make check > > > Thanks, > > Megha Sharma > >
