----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193460 -----------------------------------------------------------
LGTM sans Ilya's comment about only use `replicated_log` flag where necessary. src/master/master.cpp Line 6807 (original), 6803-6804 (patched) <https://reviews.apache.org/r/64098/#comment272010> Move `Framework* framework = getFramework(frameworkId);` down into the if condition since it's used only in there? src/tests/partition_tests.cpp Lines 402-415 (original), 403-407 (patched) <https://reviews.apache.org/r/64098/#comment272016> Expectations above `detector.appoint(master.get()->pid);` everywhere as suggested in the last review. src/tests/partition_tests.cpp Lines 716-730 (original), 710-714 (patched) <https://reviews.apache.org/r/64098/#comment272017> Ditto. src/tests/partition_tests.cpp Lines 1030-1032 (original), 1015-1025 (patched) <https://reviews.apache.org/r/64098/#comment272018> Ditto. src/tests/partition_tests.cpp Lines 2297 (patched) <https://reviews.apache.org/r/64098/#comment272024> `statusFromAgent` sounds like it's actually sent by the agent. Maybe `finsihedStatusFromMaster` for this update and rename the other `finshedStatus` to `finsihedStatusFromAgent` makes it a bit easier to distinguish? (I do understand that you meant that the status is from the agent's reregister message but I think `finsihedStatusFromMaster` vs `finsihedStatusFromAgent` is clearer). Also, can we add a comment too? e.g., the first status is sent as part of the reregistation and the second is by the agent's status update manager after it is reregsitered. - Jiang Yan Xu On Dec. 8, 2017, 10:42 a.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64098/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2017, 10:42 a.m.) > > > Review request for mesos, Ilya Pronin, James Peach, and Jiang Yan Xu. > > > Bugs: MESOS-6406 > https://issues.apache.org/jira/browse/MESOS-6406 > > > Repository: mesos > > > Description > ------- > > Master will send task status updates to frameworks when an agent > which has been previously removed by the master for being unreachable > or is unknown to the master due to the garbage collection of > the unreachable and gone agents in the registry re-registers. > > > Diffs > ----- > > src/master/master.cpp dfe60ef670edcaefa0c1241df2e2870f650fcf9e > src/tests/master_allocator_tests.cpp > 3400d70bb0ba564eac43c4639eee0efd4d8059e6 > src/tests/master_tests.cpp 57eae320a7a398527cd3623c89bf67f319a8e955 > src/tests/partition_tests.cpp 31ebfe1655438eceae74d72a223df03a9dbd282d > src/tests/persistent_volume_tests.cpp > 4aa3c2e8b0f461cd78053707cff8bcb2e6f2b0d7 > src/tests/slave_recovery_tests.cpp f14c6ef69eb20a03454c8197df79b572a3c6d050 > src/tests/upgrade_tests.cpp 7f434dbba858f636719eec24e92b306b76430c4c > > > Diff: https://reviews.apache.org/r/64098/diff/12/ > > > Testing > ------- > > with make check > > > Thanks, > > Megha Sharma > >
