----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193141 -----------------------------------------------------------
src/master/master.cpp Lines 6806-6810 (patched) <https://reviews.apache.org/r/64098/#comment271644> Also, this message will be written to the log for every task on the agent. +1 for removing it. src/master/master.cpp Lines 6814 (patched) <https://reviews.apache.org/r/64098/#comment271658> `s/registration/re-registered/` src/tests/master_tests.cpp Lines 7021 (patched) <https://reviews.apache.org/r/64098/#comment271667> Why do you need the replicated log based registry here? The master is not failing over in this test. Did I miss something? src/tests/master_tests.cpp Lines 7477 (patched) <https://reviews.apache.org/r/64098/#comment271668> Ditto re replicated log based registry. src/tests/partition_tests.cpp Lines 173 (patched) <https://reviews.apache.org/r/64098/#comment271666> Ditto re replicated log based registry. src/tests/partition_tests.cpp Lines 538 (patched) <https://reviews.apache.org/r/64098/#comment271669> Ditto re replicated log based registry. src/tests/partition_tests.cpp Lines 820 (patched) <https://reviews.apache.org/r/64098/#comment271670> Ditto re replicated log based registry. src/tests/partition_tests.cpp Lines 2151 (patched) <https://reviews.apache.org/r/64098/#comment271671> Ditto re replicated log based registry. src/tests/upgrade_tests.cpp Lines 106 (patched) <https://reviews.apache.org/r/64098/#comment271672> Ditto re replicated log based registry. - Ilya Pronin On Dec. 1, 2017, 4:29 p.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64098/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2017, 4:29 p.m.) > > > Review request for mesos, Ilya Pronin, James Peach, and Jiang Yan Xu. > > > Bugs: MESOS-6406 > https://issues.apache.org/jira/browse/MESOS-6406 > > > Repository: mesos > > > Description > ------- > > Master will send task status updates to frameworks when an agent > which has been previously removed by the master for being unreachable > or is unknown to the master due to the garbage collection of > the unreachable and gone agents in the registry re-registers. > > > Diffs > ----- > > src/master/master.cpp dfe60ef670edcaefa0c1241df2e2870f650fcf9e > src/tests/master_allocator_tests.cpp > 3400d70bb0ba564eac43c4639eee0efd4d8059e6 > src/tests/master_tests.cpp 57eae320a7a398527cd3623c89bf67f319a8e955 > src/tests/partition_tests.cpp 31ebfe1655438eceae74d72a223df03a9dbd282d > src/tests/persistent_volume_tests.cpp > 4aa3c2e8b0f461cd78053707cff8bcb2e6f2b0d7 > src/tests/slave_recovery_tests.cpp f14c6ef69eb20a03454c8197df79b572a3c6d050 > src/tests/upgrade_tests.cpp 7f434dbba858f636719eec24e92b306b76430c4c > > > Diff: https://reviews.apache.org/r/64098/diff/11/ > > > Testing > ------- > > with make check > > > Thanks, > > Megha Sharma > >
