> On Oct. 17, 2017, 7:15 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/protobuf.hpp > > Line 1 (original), 1 (patched) > > <https://reviews.apache.org/r/59987/diff/2/?file=1768786#file1768786line1> > > > > We should call out that we have a hard requirement on proto3 now in the > > `CHANGELOG`. > > > > I believe while we currently bundle protobuf-3.3.0 we do not depend on > > any proto3 features, and users might still use an unbundled protobuf-2.6.1 > > or similar (e.g., distro packages). With this change such a setup needs to > > be updated. > > Qian Zhang wrote: > Good point! I am not sure how many users are using unbundled > protobuf-2.6.1 or similar. Do you see it will be a problem if we ask them to > update to proto3? Maybe we should ask in user & dev list before merging this > patch.
Chun has mentioned it in the CHANGLOG in this patch: https://reviews.apache.org/r/64823/ , and he also made protobuf version 3+ a hard requirement for building Mesos in this patch: https://reviews.apache.org/r/64822/ . - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/#review188293 ----------------------------------------------------------- On Dec. 21, 2017, 10:07 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59987/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2017, 10:07 a.m.) > > > Review request for mesos, Anand Mazumdar, Chun-Hung Hsiao, and Zhitao Li. > > > Bugs: MESOS-7656 > https://issues.apache.org/jira/browse/MESOS-7656 > > > Repository: mesos > > > Description > ------- > > Map is a feature of proto2 syntax, but it can only be compiled > with proto3 compiler, see the following discussion for details: > https://groups.google.com/forum/#!topic/protobuf/p4WxcplrlA4 > We have already upgraded the compiler from 2.6.1 to 3.3.0 in > MESOS-7228, however, to use protobuf map in Mesos code, we also > need to add the protobuf map support to the code in Mesos for > converting protobuf message to JSON object and parsing JSON > object as protobuf message, that is what I have done in this patch. > > > Diffs > ----- > > 3rdparty/stout/include/stout/protobuf.hpp > baad12648dd78ab72ea4277f4c7f99da16696a40 > > > Diff: https://reviews.apache.org/r/59987/diff/4/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >