----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64940/#review194772 -----------------------------------------------------------
Fix it, then Ship it! Looks good to me! src/master/master.cpp Lines 10061 (patched) <https://reviews.apache.org/r/64940/#comment273750> Nit: The expression can be simplified to `!terminal && unreachable`. src/tests/master_tests.cpp Lines 7626 (patched) <https://reviews.apache.org/r/64940/#comment273751> Just curious: why do you pause the clock here? To speed up the test (i.e. not wait for `allocation_interval`)? - Ilya Pronin On Jan. 3, 2018, 5:35 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64940/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2018, 5:35 p.m.) > > > Review request for mesos, Gaston Kleiman, Jie Yu, and Jiang Yan Xu. > > > Bugs: MESOS-8337 > https://issues.apache.org/jira/browse/MESOS-8337 > > > Repository: mesos > > > Description > ------- > > If an agent is lost, we try to remove all the tasks that might > have been lost. However, if a task is already terminal, it hasn't > really been lost so we should not be tracking it in the framework's > unreachable tasks list. > > > Diffs > ----- > > src/master/master.hpp 8fe9420dbe03ea2cefc6a40b0f64284aa9fe7915 > src/master/master.cpp 282fdf8ac38e3613c621c1c8e5c50f27bde9dafd > src/tests/master_tests.cpp 5546fd937d078c1f757964d5163449ffd993388e > > > Diff: https://reviews.apache.org/r/64940/diff/1/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > >
