> On Jan. 4, 2018, 10:09 p.m., Jiang Yan Xu wrote: > > src/tests/master_tests.cpp > > Lines 7637 (patched) > > <https://reviews.apache.org/r/64940/diff/1/?file=1930131#file1930131line7637> > > > > You could just wait for the the status update (being droppped) instead > > of capaturing `Slave::executorTerminated` and risk the race condition of > > the master not receiving the status update before the agent is deemed > > partitioned?
Dealing with all the status updates was less reliable. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64940/#review194777 ----------------------------------------------------------- On Jan. 4, 2018, 1:35 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64940/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2018, 1:35 a.m.) > > > Review request for mesos, Gaston Kleiman, Jie Yu, and Jiang Yan Xu. > > > Bugs: MESOS-8337 > https://issues.apache.org/jira/browse/MESOS-8337 > > > Repository: mesos > > > Description > ------- > > If an agent is lost, we try to remove all the tasks that might > have been lost. However, if a task is already terminal, it hasn't > really been lost so we should not be tracking it in the framework's > unreachable tasks list. > > > Diffs > ----- > > src/master/master.hpp 130f6e28cc62a8912aac66ecfbf014fe1ee444e3 > src/master/master.cpp 28d8be3a4769b418b61cff0b95845e4232135bc7 > src/tests/master_tests.cpp 5546fd937d078c1f757964d5163449ffd993388e > > > Diff: https://reviews.apache.org/r/64940/diff/2/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > >
