> On Jan. 4, 2018, 12:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 165-184 (patched) > > <https://reviews.apache.org/r/64932/diff/1/?file=1930012#file1930012line165> > > > > This framework will never launch a task, so this is probably not needed. > > > > Furthermore it should probably crash if it receivres an executor > > failure... > > Greg Mann wrote: > FAILURE events can also signal that an agent was removed, so this could > happen.
Ok, that makes sense, I'd keep the `Agent failed` section and remove the other one. - Gaston ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/#review194780 ----------------------------------------------------------- On Jan. 3, 2018, 2:50 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64932/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2018, 2:50 p.m.) > > > Review request for mesos, Greg Mann and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This patch introduces an example HTTP framework which transforms > 'RAW' disk resources from resource providers into 'MOUNT' volumes and > subsequently unreserves them. > > > Diffs > ----- > > src/Makefile.am 30cd4d426e797e4c8ee556d1bc3de99830a5fe41 > src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e > src/examples/test_csi_user_framework.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/64932/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
