> On Jan. 4, 2018, 12:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 399 (patched) > > <https://reviews.apache.org/r/64932/diff/1/?file=1930012#file1930012line399> > > > > Why don't we make this a `string` instead of an `Option<string>`? > > > > That way we could remove the: `if (flags.master.isNone())` block in the > > main function. > > Benjamin Bannier wrote: > That's a great suggestion. The current code here does follow what > virtually every other example framework does though.
So we should fix it here and file a JIRA to cleanup the other example frameworks? > On Jan. 4, 2018, 12:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 444-447 (patched) > > <https://reviews.apache.org/r/64932/diff/1/?file=1930012#file1930012line444> > > > > Shouldn't this be a flag like in `no_executor_framework.cpp` and in > > `long_lived_framework.cpp`? > > Benjamin Bannier wrote: > We do appear to be inconsistent here, e.g., > `load_generator_framework.cpp`, `test_framework.cpp`, or > `test_http_framework.cpp` use an environment variable. > > I'd prefer to keep this as is and leave it for a broader cleanup which > could e.g., make it possible to load flags from both environment or command > line flags; dropping. I think that using an env variable instead of a flag is technical debt that would be trivial to fix. This is a new file, and fixing this tech debt in this file is trivial. So I think we should fix it here, and file a JIRA to do a broader cleanup of the other example frameworks later. - Gaston ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/#review194780 ----------------------------------------------------------- On Jan. 5, 2018, 4:37 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64932/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2018, 4:37 a.m.) > > > Review request for mesos, Greg Mann and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This patch introduces an example HTTP framework which transforms > 'RAW' disk resources from resource providers into 'MOUNT' volumes and > subsequently unreserves them. > > > Diffs > ----- > > src/Makefile.am 30cd4d426e797e4c8ee556d1bc3de99830a5fe41 > src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e > src/examples/test_csi_user_framework.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/64932/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
