> On Jan. 4, 2018, 12:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 444-447 (patched) > > <https://reviews.apache.org/r/64932/diff/1/?file=1930012#file1930012line444> > > > > Shouldn't this be a flag like in `no_executor_framework.cpp` and in > > `long_lived_framework.cpp`? > > Benjamin Bannier wrote: > We do appear to be inconsistent here, e.g., > `load_generator_framework.cpp`, `test_framework.cpp`, or > `test_http_framework.cpp` use an environment variable. > > I'd prefer to keep this as is and leave it for a broader cleanup which > could e.g., make it possible to load flags from both environment or command > line flags; dropping. > > Gaston Kleiman wrote: > I think that using an env variable instead of a flag is technical debt > that would be trivial to fix. This is a new file, and fixing this tech debt > in this file is trivial. > > So I think we should fix it here, and file a JIRA to do a broader cleanup > of the other example frameworks later. > > Benjamin Bannier wrote: > Fixed here and filed https://issues.apache.org/jira/browse/MESOS-8412.
Thanks for the cleanup and for the JIRA!. - Gaston ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/#review194780 ----------------------------------------------------------- On Jan. 8, 2018, 2:06 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64932/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2018, 2:06 a.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This patch introduces an example HTTP framework which transforms > 'RAW' disk resources from resource providers into 'MOUNT' volumes and > subsequently unreserves them. > > > Diffs > ----- > > src/Makefile.am bfe9eb1609c71c980c11e7cb0149caf5bdd7ab9b > src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e > src/examples/test_csi_user_framework.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/64932/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
