> On Jan. 5, 2018, 1:25 a.m., Vinod Kone wrote: > > src/tests/master_tests.cpp > > Lines 7630 (patched) > > <https://reviews.apache.org/r/64940/diff/1/?file=1930131#file1930131line7630> > > > > `the task`, which task? are both the tasks using the same executor?
We need one task to finish and one to not finish. They have separate executors. > On Jan. 5, 2018, 1:25 a.m., Vinod Kone wrote: > > src/tests/master_tests.cpp > > Lines 7645-7653 (patched) > > <https://reviews.apache.org/r/64940/diff/1/?file=1930131#file1930131line7645> > > > > Why are you launching 2 tasks instead of just one? You just want to > > test the unacknowledged terminal task case right? Doesn't really matter if > > it is TASK_FINISHED or TASK_LOST right? `TASK_LOST` is also a terminal state. So I'm distinguishing that the completed task doesn't get tracked as unreachable but that the `LOST` task does. If I didn't have any non-lost tasks, the `CHECK` would not be triggered. > On Jan. 5, 2018, 1:25 a.m., Vinod Kone wrote: > > src/tests/master_tests.cpp > > Lines 7692-7711 (patched) > > <https://reviews.apache.org/r/64940/diff/1/?file=1930131#file1930131line7692> > > > > Are you verifying that the latest state of the task has been preserved? > > I would recommend hitting "/tasks" endpoint instead of "state-summary" to > > be more direct. I'm checking that one task remained at `FINISHED` and one was moved to `LOST`. I can make the same checks using the `/tasks` endpoint, but it's going to be more code and more complicated. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64940/#review194794 ----------------------------------------------------------- On Jan. 5, 2018, 7:06 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64940/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2018, 7:06 p.m.) > > > Review request for mesos, Benjamin Mahler, Gaston Kleiman, Jie Yu, Vinod > Kone, and Jiang Yan Xu. > > > Bugs: MESOS-8337 > https://issues.apache.org/jira/browse/MESOS-8337 > > > Repository: mesos > > > Description > ------- > > If an agent is lost, we try to remove all the tasks that might > have been lost. However, if a task is already terminal, it hasn't > really been lost so we should not be tracking it in the framework's > unreachable tasks list. > > > Diffs > ----- > > src/master/master.hpp 130f6e28cc62a8912aac66ecfbf014fe1ee444e3 > src/master/master.cpp 28d8be3a4769b418b61cff0b95845e4232135bc7 > src/tests/partition_tests.cpp 3813139f576ea01db0197f0fe8a73597db1bb69a > > > Diff: https://reviews.apache.org/r/64940/diff/4/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > >
