----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review195947 -----------------------------------------------------------
src/tests/environment.cpp Lines 344-348 (patched) <https://reviews.apache.org/r/64387/#comment275377> It's a little redundant to pass in an `errorString`. Also, this method could return a `Future<Nothing>` directly. `runNetNamespaceCheck` would do the waiting/error checking. src/tests/environment.cpp Lines 378-389 (patched) <https://reviews.apache.org/r/64387/#comment275376> So these tests will be disabled until the user runs `docker pull microsoft/powershell:nanoserver` prior to running the test suite? src/tests/environment.cpp Lines 391-416 (patched) <https://reviews.apache.org/r/64387/#comment275379> If you change `launchAndWaitContainer` to return a `Future` type... you can do something like this instead: ``` Future<std::tuple<Nothing, Nothing>> checks = process::collect( launchAndWaitContainer(docker, container1, ...), launchAndWaitContainer(docker, container2, ...)); checks.await(Seconds(30)); // See if both containers succeeded or not... process::collect( docker->rm(container1, true) docker->rm(container2, true)) .await(Seconds(15)); // Possibly check if this succeeds too. ``` Using `process::collect` would parallelize some of this code. src/tests/health_check_tests.cpp Lines 2278-2284 (patched) <https://reviews.apache.org/r/64387/#comment275382> Wow... we might not want to enable this test by default if the image is that large. - Joseph Wu On Jan. 17, 2018, 4:12 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64387/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2018, 4:12 a.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston > Kleiman, Jie Yu, Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > The `HealthCheckTest.ROOT_DOCKER_*` and > `DockerContainerizerHealthCheckTest.*` tests now work on Windows. > > > Diffs > ----- > > src/tests/environment.cpp 72bd621f02f97ea5fd553f3dc0bd52adb8ddee8f > src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d > src/tests/mesos.hpp 16c75bb0ca570dfb7089743344cf38acdb517705 > > > Diff: https://reviews.apache.org/r/64387/diff/8/ > > > Testing > ------- > > Windows Server: > [==========] Running 5 tests from 2 test cases. > [----------] Global test environment set-up. > [----------] 2 tests from HealthCheckTest > [ RUN ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask > [ OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask (21263 ms) > [ RUN ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange > [ OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange (23512 ms) > [----------] 2 tests from HealthCheckTest (44835 ms total) > > [----------] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest > [ RUN ] > NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0 > [ OK ] > NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0 > (28487 ms) > [ RUN ] > NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0 > [ OK ] > NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0 > (26447 ms) > [ RUN ] > NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0 > [ OK ] > NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0 > (26264 ms) > [----------] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest > (81268 ms total) > > [----------] Global test environment tear-down > [==========] 5 tests from 2 test cases ran. (126559 ms total) > [ PASSED ] 5 tests > > Rest of tests pass. > > Windows Client (Disabled network health checks): > Proof that network health checks are skipped on Windows Client. > C:\Program Files\Docker\Docker\Resources\bin\docker.exe: Error response from > daemon: sharing of hyperv containers network is not supported. > 356b087e7fa640f83fe27ebeb3396bfc7b2bbebd917aeaec0508b887b41d31f4 > ------------------------------------------------------------- > We cannot run any Docker health checks tests because: > Running in another container's namespace is not supported on this version of > Windows. > > Rest rests pass. > > Linux: > make check passes > > > Thanks, > > Akash Gupta > >
