----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review197256 -----------------------------------------------------------
3rdparty/libprocess/src/memory_profiler.cpp Lines 654 (patched) <https://reviews.apache.org/r/63368/#comment277389> Do you need to check if the timer has been initialized? 3rdparty/libprocess/src/memory_profiler.cpp Lines 661 (patched) <https://reviews.apache.org/r/63368/#comment277390> What if stop (for some reason) request came right after timer expiration? Do you still need to call `stopaAndGenerateRawProfile()`? 3rdparty/libprocess/src/memory_profiler.cpp Lines 706-708 (patched) <https://reviews.apache.org/r/63368/#comment277391> Why this is not a simple delay? To indicate that a profiling session is running? - Alexander Rukletsov On Feb. 6, 2018, 5:45 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63368/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2018, 5:45 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This class exposes profiling functionality of jemalloc memory allocator > when it is detected to be the memory allocator of the current process. > > In particular, it gives developers an easy method to collect and > access heap profiles which report which pieces of code were > responsible for allocating memory. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 3071b7ce2b82a4ce0ea62e4d2b3518a6f5114803 > 3rdparty/libprocess/include/process/memory_profiler.hpp PRE-CREATION > 3rdparty/libprocess/include/process/process.hpp > 8661706cb058efb26f5bfbcc84972f9930d3670f > 3rdparty/libprocess/src/CMakeLists.txt > f002c157dc2ca64da66bc4e61f5095f2b533ae1f > 3rdparty/libprocess/src/memory_profiler.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > ba9bc291bb6741e32b3a066fe90771311d21852a > > > Diff: https://reviews.apache.org/r/63368/diff/4/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
